[PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[Fabian Frederick]

Fixing coccinelle warning

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org> 
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/xfs/xfs_log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 8497a00..efb8f92 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -2376,7 +2376,7 @@ next_lv:
 				if (lv)
 					vecp = lv->lv_iovecp;
 			}
-			if (record_cnt == 0 && ordered == false) {
+			if (record_cnt == 0 && !ordered) {
 				if (!lv)
 					return 0;
 				break;
-- 
1.8.3.2

Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[Andrew Morton]

On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:

> Fixing coccinelle warning

Please always quote the full error message or warning text when fixing
such things.

> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2376,7 +2376,7 @@ next_lv:
>  				if (lv)
>  					vecp = lv->lv_iovecp;
>  			}
> -			if (record_cnt == 0 && ordered == false) {
> +			if (record_cnt == 0 && !ordered) {
>  				if (!lv)
>  					return 0;

There was nothing wrong with that code.  I suspect coccinelle bustage.

Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[Joe Perches]

On Wed, 2014-04-16 at 15:15 -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:
> > Fixing coccinelle warning
[]
> > @@ -2376,7 +2376,7 @@ next_lv:
[]
> > -			if (record_cnt == 0 && ordered == false) {
> > +			if (record_cnt == 0 && !ordered) {
[]
> There was nothing wrong with that code.  I suspect coccinelle bustage.

Not really.

It's more a conceit that consistent uses of direct
boolean variable tests are less likely to be error
prone than variable comparisons to boolean literals.

Many style guides, CodingStyle not included, suggest
avoiding comparisons to boolean literals.

There is a checkpatch --strict message when comparing
a literal true/false.

I tend not to change these unless there are multiple
styles in the same subsystem/file.

Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

[Dave Chinner]

On Wed, Apr 16, 2014 at 03:15:57PM -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:
> 
> > Fixing coccinelle warning
> 
> Please always quote the full error message or warning text when fixing
> such things.

And CC the correct lists (xfs@oss.sgi.com) and/or the subsystem
maintainer (me). LKML is extremely lossy - I got behind on reading
it and so simply deleted the 10,000 queued emails, one of which was
this patch....

> > --- a/fs/xfs/xfs_log.c
> > +++ b/fs/xfs/xfs_log.c
> > @@ -2376,7 +2376,7 @@ next_lv:
> >  				if (lv)
> >  					vecp = lv->lv_iovecp;
> >  			}
> > -			if (record_cnt == 0 && ordered == false) {
> > +			if (record_cnt == 0 && !ordered) {
> >  				if (!lv)
> >  					return 0;
> 
> There was nothing wrong with that code.  I suspect coccinelle bustage.

Agreed, especially given that the variable is declared as:

	bool ordered = false;

So it can only have the values of false and true....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com