Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

Antoine Ténart
2014-04-23T08:13:12Z

Hi,

On Tue, Apr 22, 2014 at 06:54:27PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Tuesday, April 22, 2014 05:38:20 PM Antoine Ténart wrote:

[…]

> > +static struct platform_driver ahci_berlin_driver = {
> > + .probe = ahci_berlin_probe,
> > + .remove = ata_platform_remove_one,
> > + .driver = {
> > + .name = "ahci-berlin",
> > + .owner = THIS_MODULE,
> > + .of_match_table = ahci_berlin_of_match,
>
> Please add a comment explaining lack of power management support
> (i.e. that your platform doesn't have PM support implemented yet).

I can add the power management support in the v2.

Thanks!

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering