Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

Rob Herring
2014-04-22T18:54:35Z

On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:
>> Add support for the Berlin SoCs AHCI SATA controller allowing to
>> interface with devices like external hard drives.

One more thing.

>> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
>> +
>> + /* force_map is modified only if the property is found */
>> + of_property_read_u32(np, "marvell,force-port-map", &force_map);

This property does not appear to be documented.

>> + if (force_map)
>> + nports = force_map;

You don't need this as your comment says, you can just do:

of_property_read_u32(np, "marvell,force-port-map", &nports);

nports will only be changed if property is present.

Rob