Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

Antoine Ténart
2014-04-23T08:24:16Z

Rob,

On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> > <antoine.tenart@free-electrons.com> wrote:
> >> Add support for the Berlin SoCs AHCI SATA controller allowing to
> >> interface with devices like external hard drives.
>
> One more thing.
>
> >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> >> +
> >> + /* force_map is modified only if the property is found */
> >> + of_property_read_u32(np, "marvell,force-port-map", &force_map);
>
> This property does not appear to be documented.

I'll update it regarding Sebastian comments, or maybe drop it if it is
possible to enable each port individually.

>
> >> + if (force_map)
> >> + nports = force_map;
>
> You don't need this as your comment says, you can just do:
>
> of_property_read_u32(np, "marvell,force-port-map", &nports);
>
> nports will only be changed if property is present.

Sure.

Thanks!

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering