From: Lee Jones <lee.jones@linaro.org>
To: Michal Simek <monstr@monstr.eu>
Cc: Pankaj Dubey <pankaj.dubey@samsung.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] mfd: syscon: Support early initialization
Date: Wed, 23 Apr 2014 11:01:27 +0100 [thread overview]
Message-ID: <20140423100127.GF21613@lee--X1> (raw)
In-Reply-To: <53576B68.70602@monstr.eu>
> >>> Some platforms need to get system controller
> >>> ready as soon as possible.
> >>> The patch provides early_syscon_initialization
> >>> which create early mapping for all syscon compatible
> >>> devices in early_syscon_probe.
> >>> Regmap is get via syscon_early_regmap_lookup_by_phandle()
> >>>
> >>> Regular device probes attach device to regmap
> >>> via regmap_attach_dev().
> >>>
> >>> For early syscon initialization is necessary to extend
> >>> struct syscon and provide remove function
> >>> which unmap all early init structures.
> >>>
> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >>> ---
> >>>
> >>> Changes in v3:
> >>> - Keep backward compatibility for platform drivers and test it
> >>> - Use only one probe method which is early_syscon_probe
> >>> suggested by Lee Jones. Do not force anybody to call early_syscon_init
> >>> - Add kernel-doc description
> >>>
> >>> Changes in v2:
> >>> - Fix bad logic in early_syscon_probe
> >>> - Fix compilation failure for x86_64 reported by zero day testing system
> >>> - Regmap change available here
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/nodev
> >>>
> >>> drivers/mfd/syscon.c | 159 ++++++++++++++++++++++++++++++++++++++++-----
> >>> include/linux/mfd/syscon.h | 11 ++++
> >>> 2 files changed, 153 insertions(+), 17 deletions(-)
> Lee: Can you please look at these changes? It is around for a while
> and I would like to close it.
Actually I'm _still_ waiting on Arnd and Mark's opinion on this, as my
reservations from v1 still apply.
https://lkml.org/lkml/2014/2/12/149
I'll poke them now.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-04-23 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 15:00 [PATCH v3] mfd: syscon: Support early initialization Michal Simek
2014-04-10 6:20 ` Pankaj Dubey
2014-04-10 6:17 ` Michal Simek
2014-04-23 7:27 ` Michal Simek
2014-04-23 8:22 ` Pankaj Dubey
2014-04-23 8:27 ` Michal Simek
2014-04-25 13:26 ` Pankaj Dubey
2014-04-23 10:01 ` Lee Jones [this message]
2014-04-23 10:05 ` Lee Jones
2014-04-23 11:42 ` Mark Brown
2014-04-23 13:04 ` Michal Simek
2014-04-23 15:19 ` Mark Brown
2014-04-25 21:33 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423100127.GF21613@lee--X1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=pankaj.dubey@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox