public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] regulator: First pull of MFD <-> Regulator IB (v3.16)
Date: Wed, 23 Apr 2014 16:00:47 +0100	[thread overview]
Message-ID: <20140423150047.GH6264@lee--X1> (raw)
In-Reply-To: <20140423124629.GA12304@sirena.org.uk>

> > Doug Anderson (3):
> >       mfd: tps65090: Don't tell child devices we have an IRQ if we don't
> >       mfd: tps65090: Stop caching most registers
> >       regulator: tps65090: Allow setting the overcurrent wait time
> 
> Can you drop the last one please, I've already applied it?  I'd have
> expected just the first two (or probably even just the second one).  If
> you need it in your tree just grab the branch (or I can tag it if you
> like).
> 
> I tend to apply these things early where they don't have dependencies
> due to the large number of reposts for unrelated changes in the series
> that tend to happen (and often several very similar serieses being in
> flight at once); I frequently end up just deleting them unread.  Not
> sure what the best way to handle this stuff is in general.

I know that you due, which I think makes things easier for you, but
more difficult for everyone else (author, other maintainers). Applying
cross-subsystem patches also makes things difficult down the line.

Not sure what do do about the last patch now, as it has MFD changes
which aren't in the MFD tree. All well and good if no one else touches
that hunk for the remainder of the cycle, but if they do we're likely
to have merge conflicts.

I'll re-spin Monday.

> >  Documentation/devicetree/bindings/regulator/tps65090.txt |  4 ++++
> >  drivers/mfd/tps65090.c                                   | 41 +++++++++++++++++++++++++----------------
> >  drivers/power/tps65090-charger.c                         | 11 -----------
> >  drivers/regulator/tps65090-regulator.c                   | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/tps65090.h                             | 19 +++++++++++++++++++
> >  5 files changed, 104 insertions(+), 27 deletions(-)
> 
> Your formatting for these still seems to be messing up.

How so? Looks fine for me I think?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-04-23 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 11:39 [GIT PULL] regulator: First pull of MFD <-> Regulator IB (v3.16) Lee Jones
2014-04-23 12:46 ` Mark Brown
2014-04-23 15:00   ` Lee Jones [this message]
2014-04-23 18:13     ` Mark Brown
2014-04-28  9:12 ` [GIT PULL v2] " Lee Jones
2014-04-29 17:04   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423150047.GH6264@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox