public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Venkatesh Srinivas <venkateshs@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"Yan, Zheng" <zheng.z.yan@intel.com>
Subject: Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.
Date: Wed, 23 Apr 2014 17:09:12 +0200	[thread overview]
Message-ID: <20140423150912.GO11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBT5xg+zQ45dugHiXM5XFYi+V3gsBmANevx25fE0S0iNXA@mail.gmail.com>

On Wed, Apr 23, 2014 at 04:49:55PM +0200, Stephane Eranian wrote:
> On your machine, booted with 3.15-rc2, do you have /sys/devices/power?
> If not, and you have at least an SNB, you should have RAPL and that
> RAPL_UNIT MSR.
> 
> Proof is that if you read that MSR using /dev/cpu/msr it works just fine:
> # modprobe msr
> # rdmsr 0x606
> a1003
> 
> So something is broken somewhere.

I've not got SNB+ class hardware (for testing). But I believe you that
there's something funny, I just do not understanding how *msr_safe()
could cause this.

  reply	other threads:[~2014-04-23 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 19:36 [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU Venkatesh Srinivas
2014-03-14  8:44 ` Peter Zijlstra
2014-03-14 13:56   ` Andi Kleen
2014-03-14 15:21     ` Venkatesh Srinivas
2014-03-14 16:17       ` Andi Kleen
2014-03-14 16:57         ` David Ahern
2014-03-14 23:07           ` Venkatesh Srinivas
2014-04-18 13:08 ` [tip:perf/core] perf/x86/intel: Use rdmsrl_safe() " tip-bot for Venkatesh Srinivas
2014-04-23 14:31 ` [PATCH] perf/x86/intel: Use rdmsrl_safe " Stephane Eranian
2014-04-23 14:45   ` Peter Zijlstra
2014-04-23 14:49     ` Stephane Eranian
2014-04-23 15:09       ` Peter Zijlstra [this message]
2014-04-23 15:14         ` Stephane Eranian
2014-04-23 15:16           ` Borislav Petkov
2014-04-23 15:18             ` Stephane Eranian
2014-04-23 15:35               ` Borislav Petkov
2014-04-23 15:44                 ` Stephane Eranian
2014-04-23 15:55                   ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2014-03-07  4:42 Venkatesh Srinivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423150912.GO11096@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=venkateshs@google.com \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox