From: Borislav Petkov <bp@alien8.de>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, venkateshs@google.com, ak@linux.intel.com,
zheng.z.yan@intel.com
Subject: Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage
Date: Wed, 23 Apr 2014 21:00:15 +0200 [thread overview]
Message-ID: <20140423190015.GF25378@pd.tnic> (raw)
In-Reply-To: <20140423170418.GA12767@quad>
On Wed, Apr 23, 2014 at 07:04:19PM +0200, Stephane Eranian wrote:
>
> This patch fixes a bug introduced by commit 24223657.
Maybe add
Fixes: <commit-id>
tag?
> The rdmsrl_safe() function returns 0 on success.
> The current code was failing to detect the RAPL PMU
> on real hardware (missing /sys/devices/power) because
> the return value of rdmsrl_safe() was misinterpreted.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-04-23 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 17:04 [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage Stephane Eranian
2014-04-23 19:00 ` Borislav Petkov [this message]
2014-04-23 19:27 ` Venkatesh Srinivas
2014-04-23 20:00 ` Andi Kleen
2014-04-24 8:03 ` [tip:perf/urgent] perf/x86: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423190015.GF25378@pd.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=venkateshs@google.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox