Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage

Venkatesh Srinivas
2014-04-23T19:27:29Z

On Wed, Apr 23, 2014 at 12:00 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Apr 23, 2014 at 07:04:19PM +0200, Stephane Eranian wrote:
>>
>> This patch fixes a bug introduced by commit 24223657.
>
> Maybe add
>
> Fixes: <commit-id>
>
> tag?
>
>> The rdmsrl_safe() function returns 0 on success.
>> The current code was failing to detect the RAPL PMU
>> on real hardware (missing /sys/devices/power) because
>> the return value of rdmsrl_safe() was misinterpreted.
>>
>> Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Acked-by: Borislav Petkov <bp@suse.de>

Brown-Paper-Bag-Worn-By: Venkatesh Srinivas <venkateshs@google.com>

-- vs;