public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Oren Twaig <oren@scalemp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andi Kleen <ak@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	"Shai Fultheim (Shai@ScaleMP.com)" <Shai@scalemp.com>
Subject: Re: [PATCH] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore
Date: Thu, 24 Apr 2014 08:22:17 +0200	[thread overview]
Message-ID: <20140424062217.GA1104@gmail.com> (raw)
In-Reply-To: <5357D07C.5080407@scalemp.com>


* Oren Twaig <oren@scalemp.com> wrote:

> Set all inclusive vector allocation domain only if interrupt routing
> is set to ignore. When in comply mode, vector allocation behavior
> isn't changed.

This changelog is too terse:

Please update the changelog to describe the current behavior, and how 
it affects your platform. (I.e. how do users notice, if at all?)

Then describe why you think that behavior should be changed. ie: 
what's the reason for this patch.

Only then describe the details of the change itself.

> -    apic->vector_allocation_domain = fill_vector_allocation_domain;
> +
> +    if (!irc)
> +        apic->vector_allocation_domain = fill_vector_allocation_domain;

Please also run scripts/checkpatch.pl over your patch which will 
report trivial coding style problems like the one here.

Thanks,

	Ingo

  reply	other threads:[~2014-04-24  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 14:38 [PATCH] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore Oren Twaig
2014-04-24  6:22 ` Ingo Molnar [this message]
2014-04-24 14:09   ` Oren Twaig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424062217.GA1104@gmail.com \
    --to=mingo@kernel.org \
    --cc=Shai@scalemp.com \
    --cc=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oren@scalemp.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox