From: Robin Gong <b38343@freescale.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <vinod.koul@intel.com>, <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dma: imx-sdma: add support for sdma memory copy
Date: Thu, 24 Apr 2014 17:45:42 +0800 [thread overview]
Message-ID: <20140424094537.GA26556@Robin-OptiPlex-780> (raw)
In-Reply-To: <1398329406.11914.258.camel@smile.fi.intel.com>
On Thu, Apr 24, 2014 at 11:50:06AM +0300, Andy Shevchenko wrote:
> On Thu, 2014-04-24 at 13:09 +0800, Robin Gong wrote:
> > add "device_prep_dma_memcpy" and "device_prep_dma_sg" for memory copy by sdma.
> >
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> >
> > ---
> > change:
> > --v2:
> > 1. correct some printk format, such as %pad for dma_addr_t
> > 2. split duplicated code in prep_dma_memcpy and prep_dma_sg to make code clean.
>
> Thanks for an update. One small comment below.
>
> > +
> > +static int check_bd_buswidth(struct sdma_buffer_descriptor *bd,
> > + struct sdma_channel *sdmac, int count,
> > + dma_addr_t dma_dst, dma_addr_t dma_src)
> > +{
> > + int ret = 0;
> > +
> > + if (sdmac->word_size > DMA_SLAVE_BUSWIDTH_4_BYTES)
> > + ret = -EINVAL;
>
> I think two lines above are redundant since you have default path in the
> switch.
>
Thanks, will remove it in next version.
prev parent reply other threads:[~2014-04-24 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 5:09 [PATCH v2] dma: imx-sdma: add support for sdma memory copy Robin Gong
2014-04-24 8:50 ` Andy Shevchenko
2014-04-24 9:45 ` Robin Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424094537.GA26556@Robin-OptiPlex-780 \
--to=b38343@freescale.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox