From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <aarapov@redhat.com>,
David Long <dave.long@linaro.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix
Date: Thu, 24 Apr 2014 13:54:58 +0200 [thread overview]
Message-ID: <20140424115458.GA8882@redhat.com> (raw)
In-Reply-To: <20140423231728.1b95e37c@gandalf.local.home>
On 04/23, Steven Rostedt wrote:
>
> Egad, this confused the heck out of me. I didn't notice the swap in
> functions and was wondering what you were doing. I didn't realize this
> is what you meant by moving the uprobe_perf_close() up. I was thinking
> you moved the call up or something, not the function itself physically
> in the file.
...
>
> You can add by Acked-by, but next time, please make this into two
> patches. One to do the move, the other to do the change.
OK...
I tried to lessen the number of patches I have ;) But I agree, this simple
fix looks too complicated without preparation which only moves the code.
Let me split it then. Result is the same do I preserved the acks, this is
what I am going to add to my tree.
Thanks!
Oleg.
next prev parent reply other threads:[~2014-04-24 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 16:58 [PATCH 0/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() Oleg Nesterov
2014-04-23 16:58 ` [PATCH 1/1] " Oleg Nesterov
2014-04-24 3:17 ` Steven Rostedt
2014-04-24 11:54 ` Oleg Nesterov [this message]
2014-04-24 11:55 ` [PATCH v2 1/2] uprobes/tracing: Make uprobe_perf_close() visible to uprobe_perf_open() Oleg Nesterov
2014-04-24 11:55 ` [PATCH v2 2/2] uprobes/tracing: Fix uprobe_perf_open() on uprobe_apply() failure Oleg Nesterov
2014-04-24 12:37 ` [PATCH v2 0/2] uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix Steven Rostedt
2014-04-24 9:03 ` [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() Srikar Dronamraju
2014-04-24 12:27 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424115458.GA8882@redhat.com \
--to=oleg@redhat.com \
--cc=aarapov@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dave.long@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox