Re: [PATCH] drm/tilcdc increase allowable supported resolution

[Darren Etheridge <detheridge@ti.com>]

Rob Clark <robdclark@gmail.com> wrote on Thu [2014-Apr-24 16:51:04 -0400]:
> On Mon, Mar 3, 2014 at 2:08 PM, Felipe Balbi <balbi@ti.com> wrote:
> > From: Darren Etheridge <detheridge@ti.com>
> >
> > 1680x1050 appears to also be within the bandwidth capabilities
> > of the device and memory infrastructure.
> 
> For this one, is 1680x1050 possible on all devices w/ tilcdc (like 1st
> gen beaglebone (white), etc)?  If not, maybe better to keep the
> default conservative and override the default in devicetree..
> 
Fair point Rob, I didn't test BeagleBone White at that resolution, only
BeagleBone Black.  I'll redo this patch as a BBB specific dts change
given we already have a max-bandwidth DT binding in place for tilcdc.

Thanks for reviewing it.

Darren

> BR,
> -R
> 
> > Signed-off-by: Darren Etheridge <detheridge@ti.com>
> > ---
> >  drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> > index 5bb64e3..b47ec24 100644
> > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> > @@ -43,7 +43,7 @@
> >   * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to
> >   * be supportable
> >   */
> > -#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1280*1024*60)
> > +#define TILCDC_DEFAULT_MAX_BANDWIDTH  (1680*1050*60)
> >
> >
> >  struct tilcdc_drm_private {
> > --
> > 1.9.0
> >