From: Dave Young <dyoung@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: matt.fleming@intel.com, hpa@zytor.com, akpm@linux-foundation.org,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ignore ,keep for efi earlyprintk
Date: Fri, 25 Apr 2014 09:53:54 +0800 [thread overview]
Message-ID: <20140425015354.GA3224@darkstar.nay.redhat.com> (raw)
In-Reply-To: <20140424104540.GA5834@gmail.com>
On 04/24/14 at 12:45pm, Ingo Molnar wrote:
>
> * Dave Young <dyoung@redhat.com> wrote:
>
> > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory"
>
> That's a bug.
>
> >
> > Actually efi earlyprintk is using __init functions such as early_ioremap etc.
> > Thus efi earlyconsole can not be kept.
> >
> > So just ignore it and give out a warning to user.
>
> So, bugs should be fixed, not worked around.
>
> earlyprintk=,keep is really useful for the occasional difficult low
> level bug in the printk code or similar, because earlyprintk is a
> completely separate code path from printk().
I thought that earlyprintk is just for debugging before real console is available.
But it does help debugging printk as you said.
Will think about how to fix it.
Thanks
Dave
next prev parent reply other threads:[~2014-04-25 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 9:36 [PATCH] ignore ,keep for efi earlyprintk Dave Young
2014-04-24 10:45 ` Ingo Molnar
2014-04-25 1:53 ` Dave Young [this message]
2014-04-25 11:53 ` Matt Fleming
2014-04-26 7:28 ` Dave Young
2014-04-29 9:45 ` Matt Fleming
2014-04-29 10:03 ` Dave Young
2014-04-29 10:21 ` Thomas Gleixner
2014-04-30 1:12 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425015354.GA3224@darkstar.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox