From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolas Del Piano <ndel314@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, mail@berndporr.me.uk,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] Staging: comedi: drivers: fixed a coding style issue.
Date: Fri, 25 Apr 2014 10:50:20 +0300 [thread overview]
Message-ID: <20140425075020.GF26890@mwanda> (raw)
In-Reply-To: <5359DF54.50607@gmail.com>
Patches need to be sent inline. Perhaps use git send-email.
On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
>
> >From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
> From: Nicolas Del Piano <ndel314@gmail.com>
> Date: Thu, 24 Apr 2014 18:46:49 -0300
> Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
> declaration coding style.
>
We don't want these headers in the patch.
> Fixed a coding style issue.
>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
> ---
> drivers/staging/comedi/drivers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index cb5d214..71569bc 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> static void comedi_report_boards(struct comedi_driver *driv)
> {
> unsigned int i;
> +
> const char *const *name_ptr;
The original code was correct. This is a bug in checkpatch.pl. The
missing line check should count any lines starting with "const" or
"static" as declarations.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-25 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 4:06 [PATCH] Staging: comedi: drivers: fixed a coding style issue Nicolas Del Piano
2014-04-25 7:50 ` Dan Carpenter [this message]
2014-04-26 3:29 ` [rfc PATCH] checkpatch: allow multiple const * types Joe Perches
2014-04-26 19:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425075020.GF26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@berndporr.me.uk \
--cc=ndel314@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox