From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753621AbaDYOFh (ORCPT ); Fri, 25 Apr 2014 10:05:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13375 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbaDYOFf (ORCPT ); Fri, 25 Apr 2014 10:05:35 -0400 Date: Fri, 25 Apr 2014 10:04:59 -0400 From: Rik van Riel To: Randy Dunlap Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Richard Weinberger , linux-next@vger.kernel.org, "Paul E. McKenney" , umgwanakikbuti@gmail.com Subject: Re: mmotm 2014-04-24-13-07 uploaded Message-ID: <20140425100459.7824f676@annuminas.surriel.com> In-Reply-To: <535992DD.3060808@infradead.org> References: <20140424200837.727695A407C@corp2gmr1-2.hot.corp.google.com> <535992DD.3060808@infradead.org> Organization: Red Hat, Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Apr 2014 15:40:29 -0700 Randy Dunlap wrote: > uml on x86_64 defconfig: > > drivers/built-in.o: In function `__handle_sysrq': > drivers/tty/sysrq.c:514: undefined reference to `rcu_sysrq_start' > drivers/tty/sysrq.c:558: undefined reference to `rcu_sysrq_end' Randy, does the patch below fix it? Mike, this patch should also address your concerns. Andrew, this can be a -fix patch for the sysctl-rcu patch, assuming it fixes things :) Signed-off-by: Rik van Riel #include #include +#include #include #include diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c index 2ac3289..d22309c 100644 --- a/kernel/rcu/update.c +++ b/kernel/rcu/update.c @@ -322,7 +322,8 @@ int rcu_jiffies_till_stall_check(void) void rcu_sysrq_start(void) { - rcu_cpu_stall_suppress = 2; + if (!rcu_cpu_stall_suppress) + rcu_cpu_stall_suppress = 2; } void rcu_sysrq_end(void)