public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: arizona-micsupp: Fix build errors with CONFIG_OF not defined
Date: Fri, 25 Apr 2014 21:30:53 +0100	[thread overview]
Message-ID: <20140425203053.GA20707@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140425161138.GR12304@sirena.org.uk>

On Fri, Apr 25, 2014 at 05:11:38PM +0100, Mark Brown wrote:
> On Fri, Apr 25, 2014 at 04:55:40PM +0100, Charles Keepax wrote:
> 
> > Some of the OF handling functions do not have empty alternatives defined
> > if CONFIG_OF is not defined. This patch ifdefs out the offending code.
> 
> Which functions and why is it not better to provide the stubs?

Specifically of_get_child_by_name, of_parse_handle and
of_node_put, I guess stub would probably be better. I will do
a patch for that instead.

Thanks,
Charles

  reply	other threads:[~2014-04-25 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 15:55 [PATCH 1/2] regulator: arizona-micsupp: Fix build errors with CONFIG_OF not defined Charles Keepax
2014-04-25 15:55 ` [PATCH 2/2] regulator: arizona-ldo1: Fix build errors for when " Charles Keepax
2014-04-25 16:11 ` [PATCH 1/2] regulator: arizona-micsupp: Fix build errors with " Mark Brown
2014-04-25 20:30   ` Charles Keepax [this message]
2014-04-26 16:59     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425203053.GA20707@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox