* [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated
@ 2014-04-08 16:32 Paul McQuade
2014-04-25 22:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Paul McQuade @ 2014-04-08 16:32 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
WARNING: do {} while (0) macros should not be semicolon terminated
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/staging/keucr/scsiglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
index ac3d34d..fce19a4 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
do { \
if (us->fflags & value) \
SPRINTF(" " #name); \
- } while (0);
+ } while (0)
US_DO_ALL_FLAGS
#undef US_FLAG
seq_putc(m, '\n');
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated
2014-04-08 16:32 [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated Paul McQuade
@ 2014-04-25 22:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-04-25 22:23 UTC (permalink / raw)
To: Paul McQuade; +Cc: devel, linux-kernel
On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
> WARNING: do {} while (0) macros should not be semicolon terminated
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/staging/keucr/scsiglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
> do { \
> if (us->fflags & value) \
> SPRINTF(" " #name); \
> - } while (0);
> + } while (0)
> US_DO_ALL_FLAGS
> #undef US_FLAG
> seq_putc(m, '\n');
Why would you send a patch that you obviously have not at least compile
tested?
Hint, this breaks the build :(
ALWAYS test build your patches, to not do so is rude to others, don't
you agree?
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-25 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 16:32 [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated Paul McQuade
2014-04-25 22:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox