Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c

Greg KH
2014-04-25T22:31:06Z

On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
>
> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/staging/silicom/bpctl_mod.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 6b9365b..5a3d758 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -119,7 +119,10 @@ static void if_scan_init(void);
>
> static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block);
> static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
> +
> +#ifdef BP_PROC_SUPPORT
> static int bp_proc_create(void);
> +#endif

No, this code should just be removed, right?