public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sami Laine <laine.j.sami@gmail.com>
Cc: daeseok.youn@gmail.com, devel@driverdev.osuosl.org,
	trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections
Date: Sat, 26 Apr 2014 08:42:47 -0700	[thread overview]
Message-ID: <20140426154247.GA18512@kroah.com> (raw)
In-Reply-To: <20140426153033.GA4088@acer>

On Sat, Apr 26, 2014 at 06:30:33PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@gmail.com>
> 
> Sparse warning corrections:
>  - declarations made static where they should be such
>  - changed NULL-pointers as NULL instead of static 0's
>  - added __force to a few casts seemingly safe enough

You did 3 different things here, can you split this up into 3 different
patches?  Especially as someone already sent in the NULL pointer
patch...

thanks,

greg k-h

      reply	other threads:[~2014-04-26 15:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26 15:30 [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections Sami Laine
2014-04-26 15:42 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140426154247.GA18512@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daeseok.youn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=laine.j.sami@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox