Re: Kernel panic at Ubuntu: IMA + Apparmor

Oleg Nesterov
2014-04-25T20:02:18Z

On 04/25, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
>
> > Well. I _think_ that __fput() and ima_file_free() in particular should not
> > depend on current and/or current->nsproxy. If nothing else, fput() can be
> > called by the unrelated task which looks into /proc/pid/.
> >
> > But again, task_work_add() has more and more users, and it seems that even
> > __fput() paths can do "everything", so perhaps it would be safer to allow
> > to use ->nsproxy in task_work_run.
>
> Like I said, give me a clear motivating case.

I agree, we need a reason. Currently I do not see one.

> Right now not allowing
> nsproxy is turning up bugs in __fput. Which seems like a good thing.

This is what I certainly agree with ;)

Oleg.