From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Michal Marek <mmarek@suse.cz>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible
Date: Sun, 27 Apr 2014 07:14:28 +0200 [thread overview]
Message-ID: <20140427051428.GA2671@katana> (raw)
In-Reply-To: <1398558586-28931-1-git-send-email-javier@dowhile0.org>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Sun, Apr 27, 2014 at 02:29:46AM +0200, Javier Martinez Canillas wrote:
> Using the BIT() macro instead of manually shifting bits
> makes the code less error prone and also more readable.
Does it? It is a taste thing, yet I don't think it makes the code that
much more readable that it is worth changing the whole tree.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-27 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 0:29 [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible Javier Martinez Canillas
2014-04-27 5:14 ` Wolfram Sang [this message]
2014-04-27 8:58 ` [Cocci] " Javier Martinez Canillas
2014-04-27 9:36 ` Julia Lawall
2014-04-27 10:24 ` Javier Martinez Canillas
2014-04-27 10:29 ` Julia Lawall
2014-04-27 10:41 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427051428.GA2671@katana \
--to=wsa@the-dreams.de \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=javier@dowhile0.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox