From: Johan Hovold <jhovold@gmail.com>
To: Xiao Jin <jin.xiao@intel.com>
Cc: Johan Hovold <jhovold@gmail.com>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, juan.zou@intel.com,
yanmin.zhang@intel.com, david.a.cohen@linux.intel.com, "Zhang,
Qi1" <qi1.zhang@intel.com>
Subject: Re: [PATCH] usb_wwan: some improvement on write and resume
Date: Sun, 27 Apr 2014 12:27:19 +0200 [thread overview]
Message-ID: <20140427102719.GJ2206@localhost> (raw)
In-Reply-To: <535C6851.9050506@intel.com>
On Sun, Apr 27, 2014 at 10:15:45AM +0800, Xiao Jin wrote:
> > They are however two distinct bugs and should be fixed separately. Could
> > you split the fixes into two patches and resubmit?
> >
> > Please also include a more descriptive subject line for each patch, for
> > example:
> >
> > "USB: usb_wwan: fix urb leak in write error path"
> > "USB: usb_wwan: fix race between write and resume"
> >
> > You should probably point out that the write-resume race could also lead
> > to writes being reordered in the description of that patch.
> >
>
> Thanks. I will resubmit two patches.
Thanks for resending. I'll include them in the autosuspend series I'll
hopefully be able to post shortly.
Johan
prev parent reply other threads:[~2014-04-27 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 0:57 [PATCH] usb_wwan: some improvement on write and resume xiao jin
2014-04-25 9:19 ` Johan Hovold
2014-04-27 2:15 ` Xiao Jin
2014-04-27 10:27 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427102719.GJ2206@localhost \
--to=jhovold@gmail.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jin.xiao@intel.com \
--cc=juan.zou@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qi1.zhang@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox