From: Oleg Nesterov <oleg@redhat.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jim Keniston <jkenisto@us.ibm.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [RFC PATCH] uprobes: simplify rip-relative handling
Date: Sun, 27 Apr 2014 15:13:19 +0200 [thread overview]
Message-ID: <20140427131318.GA25295@redhat.com> (raw)
In-Reply-To: <20140427113040.GA17908@redhat.com>
On 04/27, Oleg Nesterov wrote:
>
> On 04/26, Denys Vlasenko wrote:
> >
> > @@ -46,7 +46,7 @@ struct arch_uprobe {
> >
> > union {
> > #ifdef CONFIG_X86_64
> > - unsigned long rip_rela_target_address;
> > + int insn_length;
> > #endif
>
> in particular, we already have auprobe->def.ilen this patch can use.
And I forgot to mention...
I can easily misunderstand the change in handle_riprel_insn(), but it
seems that since you removed memmove(cursor, ...) the changed insn has
the same lenghth as the original insn?
If yes,
- the patch is wrong, it breaks the "correction" logic
- but, at the same time, we can simplify this logic and
just kill the "long *correction" arg of riprel_post_xol.
Oleg.
next prev parent reply other threads:[~2014-04-27 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 17:29 [RFC PATCH] uprobes: add comment with insn opcodes, mnemonics and why we dont support them Denys Vlasenko
2014-04-26 17:29 ` [RFC PATCH] uprobes: simplify rip-relative handling Denys Vlasenko
2014-04-27 11:30 ` Oleg Nesterov
2014-04-27 13:13 ` Oleg Nesterov [this message]
2014-04-27 11:29 ` [RFC PATCH] uprobes: add comment with insn opcodes, mnemonics and why we dont support them Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427131318.GA25295@redhat.com \
--to=oleg@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox