From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navin.patidar@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type
Date: Mon, 28 Apr 2014 12:25:23 +0300 [thread overview]
Message-ID: <20140428092523.GS26890@mwanda> (raw)
In-Reply-To: <1398530635-3813-1-git-send-email-navin.patidar@gmail.com>
On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote:
> Use inline functions provided by USB subsystem to check endpoint type,
> instead of macros implemented by driver to do the same.
>
> Unnecessary debugging messages are also removed.
>
I like both these changes but they would have been so much easier to
review if you deleted the debugging messagese in [patch 1/2] and then
changed the endpoint functions in [patch 2/2].
> @@ -183,60 +143,36 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
> pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
>
> for (i = 0; i < pdvobjpriv->nr_endpoint; i++) {
> +
Don't put a blank line here, btw.
> + int ep_num;
> phost_endp = phost_iface->endpoint + i;
Anyway, please resend because it needs to be broken into two patches.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-28 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 16:43 [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type navin patidar
2014-04-28 9:25 ` Dan Carpenter [this message]
2014-04-29 1:36 ` navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428092523.GS26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).