From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
rashika.kheria@gmail.com, linux-kernel@vger.kernel.org,
tulinizer@gmail.com, michael.banken@mathe.stud.uni-erlangen.de,
andriy.shevchenko@linux.intel.com, lorenz@badgers.com
Subject: Re: [PATCH v2] staging: silicom: Remove unused pointer in bypass_init_module()
Date: Mon, 28 Apr 2014 22:24:55 +0300 [thread overview]
Message-ID: <20140428192455.GW26890@mwanda> (raw)
In-Reply-To: <20140428204727.699dc618@spike>
On Mon, Apr 28, 2014 at 08:47:27PM +0200, Christian Engelmayer wrote:
> Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove
> it. With the last variable declaration gone, there is no more need for an own
> block. Remove it and adapt the indenting accordingly.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> v2: Added changes requested by Dan Carpenter:
>
> Dan pointed out that with the declaration gone, the indent block shall be
> removed. This was intentionally left out in v1 in order to keep the
> changeset more readable. However, according to the input, also with the
> additional indenting change this still qualifies for one logical change.
>
> Compile tested and applies against v3.15-rc2 as well as branch staging-next
> of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Great thanks. :) You only need to work against staging next and not
v3.15-rc2 because this will go into v3.16.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2014-04-28 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 18:47 [PATCH v2] staging: silicom: Remove unused pointer in bypass_init_module() Christian Engelmayer
2014-04-28 19:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428192455.GW26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cengelma@gmx.at \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenz@badgers.com \
--cc=michael.banken@mathe.stud.uni-erlangen.de \
--cc=rashika.kheria@gmail.com \
--cc=tulinizer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox