Re: [PATCH -V1 00/22] New ACL format for better NFSv4 acl interoperability

Dave Chinner
2014-04-27T22:20:29Z

On Sun, Apr 27, 2014 at 09:44:31PM +0530, Aneesh Kumar K.V wrote:
> Hi
>
> As per LSF/MM summit discussion I am reposting the richacl patchset for
> upstream inclusion. The patchset includes minimal changes required to implement
> a new acl model similar to NFSv4 ACL. The acl model selection is based on
> file system feature flag.
>
> The following set of patches implements VFS and ext4 changes needed to implement
> a new acl model for linux. Rich ACLs are an implementation of NFSv4 ACLs,
> extended by file masks to fit into the standard POSIX file permission model.
> They are designed to work seamlessly locally as well as across the NFSv4 and
> CIFS/SMB2 network file system protocols.
>
> A user-space utility for displaying and changing richacls is available at [1]
> (a number of examples can be found at http://acl.bestbits.at/richacl/examples.html).
>
> [1] git://github.com/kvaneesh/richacl-tools.git master
>
> To test richacl on ext4, create the file sytem with richacl feature flag
> (mkfs.ext4 -O richacl or tune2fs -O richacl). With richacl feature enabled
> using mount option "acl" will switch to using richacl instead of posixacl.

No mount options, please. The ACL configuration needs to be
determined solely by the superblock feature bit - we cannot support
filesystems with mixed ACL types, and that's what this mount option
does.

> More details regarding richacl can be found at
> http://acl.bestbits.at/richacl/
>
> Previous posting of the patchset can be found at:
> http://mid.gmane.org/1319391835-5829-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com
> "[PATCH -V8 00/26] New ACL format for better NFSv4 acl interoperability"
>
> The complete patchset can also be found at:
> https://github.com/kvaneesh/linux/commits/richacl-for-upstream

Where are the tests? We need comprehensive coverage in xfstests so
we can validate that it works the way it is supposed to and that we
don't break it in future, and that all filesystems behave the same
way....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com