Re: [PATCH -V1 00/22] New ACL format for better NFSv4 acl interoperability

Christoph Hellwig
2014-04-28T09:04:04Z

On Mon, Apr 28, 2014 at 11:24:08AM +0530, Aneesh Kumar K.V wrote:
> We already do that with richacl. Richacl already have most of the
> details implemented in common code. Comparing to recent posix acl
> changes we could still simplify chmod and xattr bits. I will do that
> in the next update.

There's still tons of duplication. There should be no code in the
filesystem except for a few callouts for the inode init and chmod path,
and the attr set/get should also be mostly in a library. If you need
to add more than 20 lines to the filesystem you did something wrong.

>
> > - common data structure with Posix ACLs
> >
>
> Can you explain this ?. Why do we want to do that ?

One acl structure implementing the Posix and NFSv4 acls and instead
of a big pile of duplicate infrastructure.