From: Lee Jones <lee.jones@linaro.org>
To: micky_ching@realsil.com.cn
Cc: chris@printf.net, ulf.hansson@linaro.org, sameo@linux.intel.com,
gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, rogerable@realtek.com,
wei_wang@realsil.com.cn
Subject: Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request
Date: Tue, 29 Apr 2014 09:02:40 +0100 [thread overview]
Message-ID: <20140429080240.GC29462@lee--X1> (raw)
In-Reply-To: <cover.1398735435.git.micky_ching@realsil.com.cn>
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> The commit <mmc: rtsx: add support for pre_req and post_req> have some problem,
> using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
> these problem, and better to use a new method. So just remove it.
>
> The commit <mmc: rtsx: modify error handle and remove smatch warnings> depends
> on the previous patch. And mainly fix some problem for the previous patch. So
> need remove.
>
> Micky Ching (2):
> mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch
> warnings"
> mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"
>
> drivers/mfd/rtsx_pcr.c | 132 ++++-------
> drivers/mmc/host/rtsx_pci_sdmmc.c | 459 +++++++------------------------------
> include/linux/mfd/rtsx_common.h | 1 -
> include/linux/mfd/rtsx_pci.h | 6 -
> 4 files changed, 124 insertions(+), 474 deletions(-)
Just to clarify, what commit did you base these changes on? Have you
tested to ensure everything works as it should with these two
reversions?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-04-29 8:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 1:54 [PATCH 0/2] mmc: rtsx: revert support for mmc async request micky_ching
2014-04-29 1:54 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch warnings" micky_ching
2014-04-29 7:30 ` Ulf Hansson
2014-05-08 5:49 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove " micky
2014-05-08 7:55 ` Lee Jones
2014-05-08 8:22 ` Ulf Hansson
2014-05-09 1:09 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings" micky
2014-04-29 1:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" micky_ching
2014-04-29 7:36 ` Ulf Hansson
2014-05-05 9:31 ` Ulf Hansson
2014-05-08 7:53 ` Lee Jones
2014-05-08 5:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" micky
2014-04-29 8:02 ` Lee Jones [this message]
2014-04-30 1:32 ` [PATCH 0/2] mmc: rtsx: revert support for mmc async request micky
2014-04-29 9:45 ` [PATCH] mmc: rtsx: usb backend needs LED support Arnd Bergmann
2014-04-29 11:05 ` Ulf Hansson
2014-04-29 12:46 ` Arnd Bergmann
[not found] ` <201404300228.s3U2S7WA026782@rtits1.realtek.com>
2014-04-30 3:34 ` Roger
2014-04-30 7:00 ` Arnd Bergmann
2014-04-30 8:19 ` Ulf Hansson
2014-05-08 8:08 ` Roger
2014-05-08 8:25 ` Arnd Bergmann
2014-05-08 8:29 ` Lee Jones
2014-05-08 8:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429080240.GC29462@lee--X1 \
--to=lee.jones@linaro.org \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).