From: Will Deacon <will.deacon@arm.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH] rcutorture: don't mark torture_init_{begin,end} with __init
Date: Tue, 29 Apr 2014 09:38:32 +0100 [thread overview]
Message-ID: <20140429083831.GA26067@arm.com> (raw)
In-Reply-To: <20140428201304.GI4430@linux.vnet.ibm.com>
On Mon, Apr 28, 2014 at 09:13:04PM +0100, Paul E. McKenney wrote:
> On Mon, Apr 28, 2014 at 08:03:35PM +0100, Will Deacon wrote:
> > By the time rcutorture is initialised via its module_init callback, the
> > .init.text section of torture.ko has already been freed, so the calls to
> > torture_init{begin,end} end up branching to junk.
> >
> > This patch removes the __init annotations from torture_init_{begin,end}
> > to make sure the code is there when we want to call it.
> >
> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Good catch, and apologies for the wasted day, but someone beat you to
> this. By only 12 days, which is a bit surprising given how long this
> has been lurking.
Oh well, at least it's getting fixed!
Will
prev parent reply other threads:[~2014-04-29 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 19:03 [PATCH] rcutorture: don't mark torture_init_{begin,end} with __init Will Deacon
2014-04-28 20:13 ` Paul E. McKenney
2014-04-29 8:38 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429083831.GA26067@arm.com \
--to=will.deacon@arm.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).