From: Daeseok Youn <daeseok.youn@gmail.com>
To: axboe@fb.com
Cc: b.zolnierkie@samsung.com, kyungmin.park@samsung.com,
agordeev@redhat.com, bhansaliakhil@gmail.com,
rchinthekindi@stec-inc.com, snitzer@redhat.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] skd: remove redundant null check for kfree()
Date: Tue, 29 Apr 2014 18:31:37 +0900 [thread overview]
Message-ID: <20140429093136.GA10359@devel> (raw)
smatch says:
skd_acquire_msix() info: redundant null check
on entries calling kfree()
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/block/skd_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 608532d..fac4c08 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
return 0;
msix_out:
- if (entries)
- kfree(entries);
+ kfree(entries);
skd_release_msix(skdev);
return rc;
}
--
1.7.4.4
reply other threads:[~2014-04-29 9:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429093136.GA10359@devel \
--to=daeseok.youn@gmail.com \
--cc=agordeev@redhat.com \
--cc=axboe@fb.com \
--cc=b.zolnierkie@samsung.com \
--cc=bhansaliakhil@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rchinthekindi@stec-inc.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).