Re: [PATCH] ignore ,keep for efi earlyprintk

Dave Young
2014-04-25T01:52:32Z

On 04/24/14 at 12:45pm, Ingo Molnar wrote:
>
> * Dave Young <dyoung@redhat.com> wrote:
>
> > earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory"
>
> That's a bug.
>
> >
> > Actually efi earlyprintk is using __init functions such as early_ioremap etc.
> > Thus efi earlyconsole can not be kept.
> >
> > So just ignore it and give out a warning to user.
>
> So, bugs should be fixed, not worked around.
>
> earlyprintk=,keep is really useful for the occasional difficult low
> level bug in the printk code or similar, because earlyprintk is a
> completely separate code path from printk().

I thought that earlyprintk is just for debugging before real console is available.
But it does help debugging printk as you said.

Will think about how to fix it.

Thanks
Dave