Re: [PATCH 04/16] perf, mmap: Factor out perf_get_fd()

Peter Zijlstra
2014-04-25T14:43:14Z

On Fri, Apr 25, 2014 at 03:54:13PM +0200, Robert Richter wrote:
> I guess its this patch from Al you referring to:
>
> ea635c6 Fix racy use of anon_inode_getfd() in perf_event.c
>
> I think we do not introduce it back due to:
>
> a6fa941 perf_event: Switch to internal refcount, fix race with close()
>
> which removes the user of event_file.

linux-2.6# git show a6fa941
error: short SHA1 a6fa941 is ambiguous.
error: short SHA1 a6fa941 is ambiguous.
fatal: ambiguous argument 'a6fa941': unknown revision or path not in the working tree.

Which is I think why Linus makes us use 12 chars instead of the git
default of 8.

Of course its also entirely useless of git to not list the full IDs for
those it did find to be ambiguous.