From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Laurent Navet <laurent.navet@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: line6: fix possible overrun
Date: Tue, 29 Apr 2014 20:28:58 +0300 [thread overview]
Message-ID: <20140429172858.GD26890@mwanda> (raw)
In-Reply-To: <20140429152616.GA2316@mguzik.redhat.com>
We have two options:
1) Do we risk introducing new truncation bugs.
2) Do we risk breaking the driver because we didn't catch every
truncation bug.
Truncation bugs here are very low impact and probably no one would even
notice. That's how not worried I am about truncation bugs in this
context. It's also unlikely that we will introduce any new truncation
bugs.
Breaking the driver is very serious. But on the other hand as soon as
you proposed introducing an -EINVAL, I reviewed the driver and found the
places which would break when the code was changed. As a result of my
review then the likely hood of breakage is now low.
In other words both options are probably fine. If someone is able to
test the -EINVAL change then I would be happy to have it.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-29 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 17:09 [PATCH] staging: line6: fix possible overrun Laurent Navet
2014-04-26 20:47 ` Mateusz Guzik
2014-04-26 21:36 ` Dan Carpenter
2014-04-26 21:59 ` Mateusz Guzik
2014-04-27 17:39 ` Dan Carpenter
2014-04-27 19:05 ` Laurent Navet
2014-04-27 20:00 ` Mateusz Guzik
2014-04-27 22:44 ` Dan Carpenter
2014-04-29 14:47 ` Takashi Iwai
2014-04-29 15:02 ` Dan Carpenter
2014-04-29 15:26 ` Mateusz Guzik
2014-04-29 17:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429172858.GD26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.navet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox