From: Mateusz Guzik <mguzik@redhat.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kent Overstreet <kmo@daterainc.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] aio: change exit_aio() to load mm->ioctx_table once and avoid rcu_read_lock()
Date: Wed, 30 Apr 2014 01:04:58 +0200 [thread overview]
Message-ID: <20140429230457.GA4604@mguzik.redhat.com> (raw)
In-Reply-To: <20140429212222.GA28959@kvack.org>
On Tue, Apr 29, 2014 at 05:22:22PM -0400, Benjamin LaHaise wrote:
> On Tue, Apr 29, 2014 at 04:42:17PM -0400, Benjamin LaHaise wrote:
> > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> >
> > Your patch does not apply because it is whitespace damaged. Please resend
> > and verify that it applies with 'git am'.
>
> Whoops, it's not whitespace damange, but rather that it doesn't apply with
> the other changes that are queued up in the aio-next tree. You can find a
> copy of that tree at git://git.kvack.org/~bcrl/aio-next.git . The change
> that conflicts is an additional parameter to kill_ioctx().
While here is there any reason for:
rcu_assign_pointer(mm->ioctx_table, NULL);
Nothing looks at this pointer afterwards and mm is about to be freed.
I thought it would be used to sanity check that everything was cleared
before freeing, but that is nod one and not every pointer is nullified
anyway.
--
Mateusz Guzik
next prev parent reply other threads:[~2014-04-29 23:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 18:39 [PATCH 0/1] aio: change exit_aio() to load mm->ioctx_table once and avoid rcu_read_lock() Oleg Nesterov
2014-04-29 18:39 ` Oleg Nesterov
2014-04-29 23:36 ` Kent Overstreet
2014-04-29 18:40 ` [PATCH 1/1] " Oleg Nesterov
2014-04-29 20:42 ` Benjamin LaHaise
2014-04-29 21:22 ` Benjamin LaHaise
2014-04-29 23:04 ` Mateusz Guzik [this message]
2014-04-30 12:13 ` Oleg Nesterov
2014-04-30 14:15 ` [PATCH v2 0/2] aio: ioctx_table/rcu_read_lock cleanups Oleg Nesterov
2014-04-30 14:16 ` [PATCH v2 1/2] aio: change exit_aio() to load mm->ioctx_table once and avoid rcu_read_lock() Oleg Nesterov
2014-04-30 15:23 ` Benjamin LaHaise
2014-04-30 17:02 ` [PATCH v3 " Oleg Nesterov
2014-04-30 14:16 ` [PATCH v2 2/2] aio: kill the misleading rcu read locks in ioctx_add_table() and kill_ioctx() Oleg Nesterov
2014-04-29 19:33 ` [PATCH 0/1] aio: change exit_aio() to load mm->ioctx_table once and avoid rcu_read_lock() Benjamin LaHaise
2014-04-29 19:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429230457.GA4604@mguzik.redhat.com \
--to=mguzik@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=kmo@daterainc.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox