Re: [patch] lib: check for strcpy() overflows to fixed length buffers

Dan Carpenter
2014-05-06T12:42:40Z

On Wed, Apr 30, 2014 at 11:15:29PM +0300, Dan Carpenter wrote:
> > > diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h
> > > index e863dd5..5e0fc2b 100644
> > > --- a/include/acpi/platform/acenv.h
> > > +++ b/include/acpi/platform/acenv.h
> >
> > This is an ACPICA header and changes to it need to be submitted to the ACPICA
> > maintainers (as per MAINTAINERS). We only get ACPICA changes from the
> > upstream project (except for really special situations).
>
> Ok. I should have added Robert and Lv to the CC list. My guess is
> that the (void) is needed to avoid compile warnings but it's needed for
> us to avoid compile breakage with this change.
>
> Anyway, I'll wait for a couple days and resend that bit broken out.
>

In the end, I won't need to modify the ACPICA headers if I use an
expression statement ({ ... }) instead of a do { } while (0) statement.

Thanks, though. :)

regards,
dan carpenter