From: Dan Carpenter <dan.carpenter@oracle.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com
Subject: Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path
Date: Wed, 30 Apr 2014 21:51:17 +0300 [thread overview]
Message-ID: <20140430185116.GH26890@mwanda> (raw)
In-Reply-To: <1398878071-21307-1-git-send-email-kys@microsoft.com>
On Wed, Apr 30, 2014 at 10:14:31AM -0700, K. Y. Srinivasan wrote:
> + /* Setup state for managing the send buffer. */
> + net_device->map_words = DIV_ROUND_UP(net_device->send_section_cnt,
> + BITS_PER_LONG);
> +
> + net_device->send_section_map =
> + kzalloc(net_device->map_words * sizeof(ulong), GFP_KERNEL);
> + if (net_device->send_section_map == NULL)
> + goto cleanup;
I told you about this returning success bug if kmalloc() fails but you
didn't fix it.
> +
> goto exit;
>
> cleanup:
> - netvsc_destroy_recv_buf(net_device);
> + netvsc_destroy_buf(net_device);
>
> exit:
> return ret;
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-30 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 17:14 [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path K. Y. Srinivasan
2014-04-30 17:36 ` David Miller
2014-04-30 18:51 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-23 21:24 K. Y. Srinivasan
2014-04-23 21:45 ` Dan Carpenter
2014-04-24 21:49 ` Andev
2014-04-24 22:06 ` KY Srinivasan
2014-04-24 22:30 ` Dan Carpenter
2014-04-30 14:17 ` KY Srinivasan
2014-04-30 16:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430185116.GH26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox