public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Zummo <a.zummo@towertech.it>
To: Raghavendra Ganiga <ravi23ganiga@gmail.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344
Date: Wed, 30 Apr 2014 22:35:07 +0200	[thread overview]
Message-ID: <20140430223507.0c011284@linux.lan.towertech.it> (raw)
In-Reply-To: <1398875107-19450-1-git-send-email-ravi23ganiga@gmail.com>

On Wed, 30 Apr 2014 21:55:07 +0530
Raghavendra Ganiga <ravi23ganiga@gmail.com> wrote:

> +
> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
> +{
> +	struct ds1343_priv *priv = dev_get_drvdata(dev);
> +	unsigned int data;
> +	unsigned char alarm_mode = 0;
> +	const char *alarm_str, *diodes = "disabled", *resistors = " ";
> +
> +	regmap_read(priv->map, DS1343_CONTROL_REG, &data);

 is this thing really useful? what about having sysfs entries
 instead?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


  reply	other threads:[~2014-04-30 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 16:25 [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344 Raghavendra Ganiga
2014-04-30 20:35 ` Alessandro Zummo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-06 19:03 Raghavendra Ganiga
2014-05-07 21:42 ` Andrew Morton
2014-05-07 22:15   ` Alan Cox
2014-05-07 22:22     ` Andrew Morton
2014-04-13 14:42 RAGHAVENDRA GANIGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430223507.0c011284@linux.lan.towertech.it \
    --to=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi23ganiga@gmail.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox