From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t
Date: Wed, 30 Apr 2014 17:07:50 -0700 [thread overview]
Message-ID: <20140501000750.GB21775@kroah.com> (raw)
In-Reply-To: <20140430203321.30056.14833.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Wed, Apr 30, 2014 at 02:33:21PM -0600, Bjorn Helgaas wrote:
> dma_declare_coherent_memory() takes two addresses for a region of memory: a
> "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is
> the physical address a *CPU* would use to access the region, and
> "device_addr" is the bus address the *device* would use to address the
> region.
>
> Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t.
Isn't this going to cause problems with the callers of this function?
You aren't changing them...
greg k-h
next prev parent reply other threads:[~2014-05-01 0:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 20:33 [PATCH] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t Bjorn Helgaas
2014-05-01 0:07 ` Greg Kroah-Hartman [this message]
2014-05-01 7:48 ` Bjorn Helgaas
2014-05-01 14:08 ` James Bottomley
2014-05-01 19:05 ` Bjorn Helgaas
2014-05-02 6:11 ` James Bottomley
2014-05-02 8:42 ` Arnd Bergmann
2014-05-05 23:01 ` Bjorn Helgaas
2014-05-06 2:42 ` James Bottomley
2014-05-06 9:29 ` Arnd Bergmann
2014-05-06 13:18 ` Bjorn Helgaas
2014-05-06 13:42 ` James Bottomley
2014-05-06 14:09 ` Arnd Bergmann
2014-05-02 18:34 ` Bjorn Helgaas
2014-05-02 11:18 ` Liviu Dudau
2014-05-05 22:42 ` Bjorn Helgaas
2014-05-06 8:59 ` Liviu Dudau
2014-05-06 20:22 ` Bjorn Helgaas
2014-05-02 11:02 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501000750.GB21775@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=JBottomley@parallels.com \
--cc=bhelgaas@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox