From: David Miller <davem@davemloft.net>
To: alchark@gmail.com
Cc: rl@hellgate.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, David.Laight@ACULAB.COM,
mq@suse.cz
Subject: Re: [PATCH] net: via-rhine: Drop revision property, use quirks instead
Date: Fri, 02 May 2014 15:56:35 -0400 (EDT) [thread overview]
Message-ID: <20140502.155635.1691085402453175737.davem@davemloft.net> (raw)
In-Reply-To: <1398882069-28872-1-git-send-email-alchark@gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1103 bytes --]
From: Alexey Charkov <alchark@gmail.com>
Date: Wed, 30 Apr 2014 22:21:09 +0400
> This adds two new flags to quirks and thus removes the need to carry
> revision in rhine_private. As a result, the init logic is simplified
> a bit.
>
> This also fixes a compiler warning in OF code on 64bit due to pointer
> casting:
>
> drivers/net/ethernet/via/via-rhine.c: In function ¡rhine_init_one_platform¢:
> drivers/net/ethernet/via/via-rhine.c:1132:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> revision = (u32)match->data;
> ^
>
> That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765
> ("net: via-rhine: add OF bus binding").
>
> Tested in platform configuration on a VIA WM8950 APC Rock board.
>
> Reported-by: Jan Moskyto Matejka <mq@suse.cz>
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
This looks a lot better, applied, thanks.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2014-05-02 19:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 17:36 [PATCH] net: via-rhine: fix compiler warning Jan Moskyto Matejka
2014-04-29 18:09 ` Alexey Charkov
2014-04-29 19:47 ` Jan Moskyto Matejka
2014-04-30 8:49 ` David Laight
2014-04-30 9:22 ` Alexey Charkov
2014-04-30 9:35 ` David Laight
2014-04-30 12:06 ` [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit Alexey Charkov
2014-04-30 18:21 ` [PATCH] net: via-rhine: Drop revision property, use quirks instead Alexey Charkov
2014-05-02 19:56 ` David Miller [this message]
2014-05-03 12:40 ` [PATCH] net: via-rhine: Convert #ifdef USE_MMIO to a runtime flag Alexey Charkov
2014-05-05 19:37 ` David Miller
2014-05-01 9:30 ` [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit David Laight
2014-05-01 11:33 ` Alexey Charkov
2014-04-30 9:50 ` [PATCH] net: via-rhine: fix compiler warning Jan Moskyto Matejka
2014-04-30 9:57 ` David Laight
2014-04-30 10:08 ` Jan Moskyto Matejka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502.155635.1691085402453175737.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=alchark@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mq@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).