From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbaEBT4i (ORCPT ); Fri, 2 May 2014 15:56:38 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37011 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbaEBT4h (ORCPT ); Fri, 2 May 2014 15:56:37 -0400 Date: Fri, 02 May 2014 15:56:35 -0400 (EDT) Message-Id: <20140502.155635.1691085402453175737.davem@davemloft.net> To: alchark@gmail.com Cc: rl@hellgate.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David.Laight@ACULAB.COM, mq@suse.cz Subject: Re: [PATCH] net: via-rhine: Drop revision property, use quirks instead From: David Miller In-Reply-To: <1398882069-28872-1-git-send-email-alchark@gmail.com> References: <1398859589-22346-1-git-send-email-alchark@gmail.com> <1398882069-28872-1-git-send-email-alchark@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 May 2014 12:56:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s42JuiKH023485 From: Alexey Charkov Date: Wed, 30 Apr 2014 22:21:09 +0400 > This adds two new flags to quirks and thus removes the need to carry > revision in rhine_private. As a result, the init logic is simplified > a bit. > > This also fixes a compiler warning in OF code on 64bit due to pointer > casting: > > drivers/net/ethernet/via/via-rhine.c: In function rhine_init_one_platform: > drivers/net/ethernet/via/via-rhine.c:1132:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > revision = (u32)match->data; > ^ > > That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 > ("net: via-rhine: add OF bus binding"). > > Tested in platform configuration on a VIA WM8950 APC Rock board. > > Reported-by: Jan Moskyto Matejka > Signed-off-by: Alexey Charkov This looks a lot better, applied, thanks. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I