public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Karim Raslan <karim.allah.ahmed@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	SeongJae Park <sj38.park@gmail.com>,
	John Stultz <john.stultz@linaro.org>,
	Cruz Julian Bishop <cruzjbishop@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixing coding style issues in android alarm-dev.c
Date: Fri, 2 May 2014 10:29:05 +0300	[thread overview]
Message-ID: <20140502072905.GA4963@mwanda> (raw)
In-Reply-To: <1398891959-10437-1-git-send-email-karim.allah.ahmed@gmail.com>

On Wed, Apr 30, 2014 at 10:05:53PM +0100, Karim Raslan wrote:
> fixing "Missing a blank line after declarations" found by checkpatch.pl script
> 

Use a subject prefix.  Also the subject is too vague.

[PATCH] staging: android: alarm-dev: add a blank line

regards,
dan carpenter


      reply	other threads:[~2014-05-02  7:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 21:05 [PATCH] Fixing coding style issues in android alarm-dev.c Karim Raslan
2014-05-02  7:29 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140502072905.GA4963@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=cruzjbishop@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=karim.allah.ahmed@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj38.park@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox