* [PATCH] Fixing coding style issues in android alarm-dev.c
@ 2014-04-30 21:05 Karim Raslan
2014-05-02 7:29 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Karim Raslan @ 2014-04-30 21:05 UTC (permalink / raw)
Cc: Karim Raslan, Greg Kroah-Hartman, SeongJae Park, Dan Carpenter,
John Stultz, Cruz Julian Bishop, devel, linux-kernel
fixing "Missing a blank line after declarations" found by checkpatch.pl script
Signed-off-by: Karim Raslan <karim.allah.ahmed@gmail.com>
---
drivers/staging/android/alarm-dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 2fc7cdd..f200e8a 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -329,6 +329,7 @@ static int alarm_release(struct inode *inode, struct file *file)
if (file->private_data) {
for (i = 0; i < ANDROID_ALARM_TYPE_COUNT; i++) {
uint32_t alarm_type_mask = 1U << i;
+
if (alarm_enabled & alarm_type_mask) {
alarm_dbg(INFO,
"%s: clear alarm, pending %d\n",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixing coding style issues in android alarm-dev.c
2014-04-30 21:05 [PATCH] Fixing coding style issues in android alarm-dev.c Karim Raslan
@ 2014-05-02 7:29 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-05-02 7:29 UTC (permalink / raw)
To: Karim Raslan
Cc: Greg Kroah-Hartman, SeongJae Park, John Stultz,
Cruz Julian Bishop, devel, linux-kernel
On Wed, Apr 30, 2014 at 10:05:53PM +0100, Karim Raslan wrote:
> fixing "Missing a blank line after declarations" found by checkpatch.pl script
>
Use a subject prefix. Also the subject is too vague.
[PATCH] staging: android: alarm-dev: add a blank line
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-02 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-30 21:05 [PATCH] Fixing coding style issues in android alarm-dev.c Karim Raslan
2014-05-02 7:29 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox