From: Steve Capper <steve.capper@linaro.org>
To: Mark Salter <msalter@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] arm64: TLB flush issues
Date: Fri, 2 May 2014 16:30:21 +0100 [thread overview]
Message-ID: <20140502153019.GA9179@linaro.org> (raw)
In-Reply-To: <1399044035-11274-1-git-send-email-msalter@redhat.com>
On Fri, May 02, 2014 at 11:20:33AM -0400, Mark Salter wrote:
> As explained in more detail in the second patch, I have observed a soft
> lockup under some loads. These lockups were in flush_tlb_kernel_range()
> which was looping through a very large address range. While looking into
> this, I also noticed the flush routines in tlb.S were not properly
> handling pages larger than 4k. This is corrected in the first patch.
> The second patch limits the loop size for the flush_tlb_[kernel_]range
> functions. It uses an arbitrary constant to limit the loop, but it
> would be better if it were based on actual tlb size or some other
> heuristic.
>
> Mark Salter (2):
> arm64: fix unnecessary tlb flushes
> arm64: fix soft lockup due to large tlb flush range
>
> arch/arm64/include/asm/tlbflush.h | 28 +++++++++++++++++++++++++---
> arch/arm64/mm/tlb.S | 4 ++--
> 2 files changed, 27 insertions(+), 5 deletions(-)
>
Hi Mark,
As a heads-up, I posted this earlier today:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/252837.html
Cheers,
--
Steve
next prev parent reply other threads:[~2014-05-02 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 15:20 [PATCH 0/2] arm64: TLB flush issues Mark Salter
2014-05-02 15:20 ` [PATCH 1/2] arm64: fix unnecessary tlb flushes Mark Salter
2014-05-02 15:20 ` [PATCH 2/2] arm64: fix soft lockup due to large tlb flush range Mark Salter
2014-05-02 15:30 ` Steve Capper [this message]
2014-05-02 15:50 ` [PATCH 0/2] arm64: TLB flush issues Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502153019.GA9179@linaro.org \
--to=steve.capper@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox