From: Mateusz Guzik <mguzik@redhat.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] mm/zswap.c: add lock helper
Date: Fri, 2 May 2014 20:22:00 +0200 [thread overview]
Message-ID: <20140502182158.GC13207@mguzik.redhat.com> (raw)
In-Reply-To: <20140502183510.21ee4a06d787b3882e77faba@skynet.be>
On Fri, May 02, 2014 at 06:35:10PM +0200, Fabian Frederick wrote:
> &tree->lock is used all over the place
>
[..]
> + spinlock_t *lock = &tree->lock;
>
> if (!tree)
> return;
>
Rather fishy, although I'm unsure if this is a real problem.
--
Mateusz Guzik
prev parent reply other threads:[~2014-05-02 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 16:35 [PATCH 1/1] mm/zswap.c: add lock helper Fabian Frederick
2014-05-02 18:22 ` Mateusz Guzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502182158.GC13207@mguzik.redhat.com \
--to=mguzik@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox