Re: [PATCH] staging: android: fix missing a blank line after declarations

Joe Perches
2014-05-05T19:51:13Z

On Mon, 2014-05-05 at 12:59 +0300, Dan Carpenter wrote:
> On Sat, May 03, 2014 at 07:43:26PM -0400, Greg KH wrote:
> > On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> > > On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > > > This patch fixes "Missing a blank line after declarations" warnings.
> > > >
> > > > Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> > >
> > > Quite a few of these are false checkpatch.pl false positives. Just
> > > ignore the false positives.
> >
> > Really? It looks good to me, what am I missing?
> >
>
> Gar. You're right. In my head I remember seeing a bunch of false
> positives but now that I'm looking at it again I'm not sure what I was
> talking about.

I think they were around here:

> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -228,8 +230,10 @@ struct binder_node {
> int internal_strong_refs;
> int local_weak_refs;
> int local_strong_refs;
> +
> binder_uintptr_t ptr;
> binder_uintptr_t cookie;
> +
> unsigned has_strong_ref:1;

These 2 new blank lines aren't necessary.