From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/comedi: fix sparse warning: shift too big
Date: Sat, 3 May 2014 19:58:38 -0400 [thread overview]
Message-ID: <20140503235838.GA20243@kroah.com> (raw)
In-Reply-To: <1399042624-9441-1-git-send-email-brilliantov@inbox.ru>
On Fri, May 02, 2014 at 06:57:04PM +0400, Brilliantov Kirill Vladimirovich wrote:
> Signed-off-by: Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru>
> ---
> drivers/staging/comedi/drivers/ni_stc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h
> index f0630b78..197b568 100644
> --- a/drivers/staging/comedi/drivers/ni_stc.h
> +++ b/drivers/staging/comedi/drivers/ni_stc.h
> @@ -717,7 +717,7 @@ enum AI_AO_Select_Bits {
> static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel)
> {
> if (channel < 4)
> - return 1 << channel;
> + return 1 << (channel & 0x3);
That change does nothing, so it's not worth applying, don't you agree?
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-04 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 14:57 [PATCH] staging/comedi: fix sparse warning: shift too big Brilliantov Kirill Vladimirovich
2014-05-02 16:49 ` Ian Abbott
2014-05-02 18:28 ` Hartley Sweeten
2014-05-02 20:24 ` Ian Abbott
2014-05-03 23:58 ` Greg Kroah-Hartman [this message]
2014-05-04 7:46 ` Brilliantov Kirill Vladimirovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140503235838.GA20243@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=brilliantov@inbox.ru \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox