public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
	linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
	alexandre.f.demers@gmail.com
Subject: Re: [PATCH] staging: rtl8712: fix potential leaks in r8712_set_key()
Date: Sat, 3 May 2014 20:27:35 -0400	[thread overview]
Message-ID: <20140504002735.GA16794@kroah.com> (raw)
In-Reply-To: <20140501235402.48ced880@spike>

On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote:
> Fix potential leaks in the error paths of r8712_set_key(). In case the
> algorithm specific checks fail, the function returns without enqueuing
> or freeing the already allocated command and parameter structs. Use a
> centralized exit path and make sure that all memory is freed correctly.
> Detected by Coverity - CID 144370, 144371.
> 
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

This doesn't apply either, and neither does one of your other patches,
what is going on?

Can you just refresh all of the outstanding patches you have sent me
that I have not applied and resend them?

thanks,

greg k-h

  reply	other threads:[~2014-05-04  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 21:54 [PATCH] staging: rtl8712: fix potential leaks in r8712_set_key() Christian Engelmayer
2014-05-04  0:27 ` Greg KH [this message]
2014-05-05 20:14   ` Christian Engelmayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140504002735.GA16794@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=alexandre.f.demers@gmail.com \
    --cc=cengelma@gmx.at \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox