From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932391AbaEEMgZ (ORCPT ); Mon, 5 May 2014 08:36:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17608 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932167AbaEEMgX (ORCPT ); Mon, 5 May 2014 08:36:23 -0400 Date: Mon, 5 May 2014 15:36:03 +0300 From: Dan Carpenter To: Martin Kepplinger Cc: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, lidza.louina@gmail.com Subject: Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk() Message-ID: <20140505123603.GQ26890@mwanda> References: <1398765250-16064-1-git-send-email-martink@posteo.de> <1399285779-7040-1-git-send-email-martink@posteo.de> <20140505113507.GP26890@mwanda> <53677D1D.5000204@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53677D1D.5000204@posteo.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote: > Am 2014-05-05 13:35, schrieb Dan Carpenter: > > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote: > >> Use dev_err() instead of printk() and remove "dgnc:" from the message. > >> This should provide userspace with more useful information and use > >> the common kernel coding style. > >> > > > > Whenever I see a "RESEND" in a subject and no explanation then it means > > our development process has broken down. Meanwhile this is the first > > time I have seen this patch so the problem is not on our side. > > > > regards, > > dan carpenter > > > > I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week > or so. I don't see any breakdown. What I'm saying is just put an explanation after the --- cut off so we know what you did wrong the first time. Signed-off-by ... --- Resending because I sent it to the wrong email list the first time. Oops! Next time I will use get_maintainer.pl, I promise! Just a simple explanation like that is ok. regards, dan carpenter