Re: [PATCH 21/24] net, diet: Make packet tpacket/mmap/fanout/rings optional

David Miller
2014-05-06T03:09:28Z

From: Andi Kleen <andi@firstfloor.org>
Date: Mon, 5 May 2014 15:26:10 -0700

> From: Andi Kleen <ak@linux.intel.com>
>
> Many DHCP clients need basic packet sockets, but they don't need
> the fancy zero copy packet capture code, like tpacket, mmap, rings,
> fanouts. This is quite substantial code, so it's worthwhile to
> make it optional
>
> Worth nearly 10k code.
>
> text data bss dec hex filename
> 952827 71874 25352 1050053 1005c5 net/built-in.o-with-packet-mmap
> 943211 71810 25352 1040373 fdff5 net/built-in.o-wo-packet-mmap
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Sorry, I'm not applying this either.

Small systems use packet generation and reception tools commonly, and
the only sane way to do so is with tpacket.