From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
forest@alittletooquiet.net, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] staging: vt6656: make spin_lock_irq() human readable
Date: Tue, 6 May 2014 11:37:10 +0300 [thread overview]
Message-ID: <20140506083709.GS26890@mwanda> (raw)
In-Reply-To: <1399355919-26684-1-git-send-email-martink@posteo.de>
On Tue, May 06, 2014 at 07:58:39AM +0200, Martin Kepplinger wrote:
> Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
> Thus do all locking in main_usb.c and hold it for a insignificantly
> shorter period of time. This makes the affected area significantly more
> readable though.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2014-05-06 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 17:01 [PATCH] staging: vt6656: make spin_lock_irq() human readable Martin Kepplinger
2014-05-06 5:58 ` [RESEND PATCH] " Martin Kepplinger
2014-05-06 8:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506083709.GS26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox