* [patch] drbd: silence underflow warning in read_in_block()
@ 2014-05-06 11:28 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-05-06 11:28 UTC (permalink / raw)
To: Lars Ellenberg; +Cc: drbd-user, linux-kernel, kernel-janitors
My static checker warns that "data_size" could be negative and underflow
the limit check. The code looks suspicious but I don't know if it is a
real bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index b6c8aaf..15daf86d 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -1528,7 +1528,7 @@ read_in_block(struct drbd_peer_device *peer_device, u64 id, sector_t sector,
struct drbd_peer_request *peer_req;
struct page *page;
int dgs, ds, err;
- int data_size = pi->size;
+ unsigned int data_size = pi->size;
void *dig_in = peer_device->connection->int_dig_in;
void *dig_vv = peer_device->connection->int_dig_vv;
unsigned long *data;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-05-06 11:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 11:28 [patch] drbd: silence underflow warning in read_in_block() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox